Cast nulls as lists or intervals to avoid ambiguities#49
Open
antvaset wants to merge 1 commit intocqframework:mainfrom
Open
Cast nulls as lists or intervals to avoid ambiguities#49antvaset wants to merge 1 commit intocqframework:mainfrom
antvaset wants to merge 1 commit intocqframework:mainfrom
Conversation
suyashkumar
approved these changes
Aug 25, 2024
brynrhodes
requested changes
Aug 26, 2024
Member
brynrhodes
left a comment
brynrhodes
left a comment
There was a problem hiding this comment.
I left this comment on the related PR in the Java CQL engine as well, but I don't understand why we would need to cast the null in the list operator cases? Shouldn't it resolve to a list since one of the arguments is known to be list-valued?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few test cases in which
nulls technically can be resolved as either Lists or Intervals. For example,null contains 5can be interpreted as eitherContains(List<Integer>, Integer)orContains(Interval<Integer>, Integer).This PR adds explicit casts to the cases with such ambiguities.