Add Write(const char* const , size_t) for #177#187
Open
naga-karupi wants to merge 1 commit intocrayzeewulf:masterfrom
Open
Add Write(const char* const , size_t) for #177#187naga-karupi wants to merge 1 commit intocrayzeewulf:masterfrom
naga-karupi wants to merge 1 commit intocrayzeewulf:masterfrom
Conversation
Collaborator
|
Hi @naga-karupi , I'm sorry this has sat for so long. My initial concern about writing a char* led me to drag my feet and eventually forget about getting back to you. I apologize for that. I've build and run your branch, everything is still functioning, but I don't have a unit test to verify your work. If you are still interested in this PR, would you be willing to add a unit test as you had asked about? It should be very straightforward, just add to this one or copy/paste a similar. I will get it tested right away if you are able. @crayzeewulf , any thoughts? Thanks for your contribution @naga-karupi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Write(const char* const dataCharArray, size_t size)for #177.I comfarmed it can be built.
I have not writen gtest yet. So please reply if I need to write gtest.