replace bootstrapified "tab group" dashboard card with an actual angular component#97
Open
guss77 wants to merge 2 commits intocreativetimofficial:masterfrom
Open
replace bootstrapified "tab group" dashboard card with an actual angular component#97guss77 wants to merge 2 commits intocreativetimofficial:masterfrom
guss77 wants to merge 2 commits intocreativetimofficial:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard view is very pretty, but it isn't really built with Angular - it is a bunch of boostrap-style UI elements, and is therefore to verbose and hard to customize and re-use.
I suggest replacing the widgets in the dashboard with Angular components that are customizable and reusable.
Here is the first one - the tabbed card (Labeled "Tasks") as an angular component.
We can probably add more customization options (I'm particularly looking at the
labelfield that is just a text string at the moment) and useMatCards and other Angular Material components instead of styled divs, but this PR is fully functional drop-in replacement to the current implementation and offers:colorattribute, I couldn't think of a better name)