fix: cast latest_n to int in LTMSQLiteStorage to prevent SQL injection#4325
Open
RinZ27 wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: cast latest_n to int in LTMSQLiteStorage to prevent SQL injection#4325RinZ27 wants to merge 1 commit intocrewAIInc:mainfrom
RinZ27 wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the 'latest_n' parameter was being directly interpolated into the SQL query strings in 'LTMSQLiteStorage'. While it's expected to be an integer, casting it explicitly to 'int' ensures that no malicious strings can be injected into the 'LIMIT' clause, especially in an AI agent context where input sources can be unpredictable. This also allows for better error handling if an invalid type is passed.
Note
Medium Risk
Low-impact security hardening, but it changes runtime behavior by raising on non-numeric
latest_n(not currently caught by the existing sqlite-only exception handling).Overview
Security hardening:
LTMSQLiteStorage.loadandLTMSQLiteStorage.aloadnow castlatest_ntointbefore interpolating it into the SQLLIMITclause, reducing the risk of injection through an unexpected/non-integer value.This may surface new failures for invalid
latest_ninputs (e.g.,ValueError) rather than silently executing a query.Written by Cursor Bugbot for commit 7fe4020. This will update automatically on new commits. Configure here.