Fix deprecated rand.Seed and Crontab.Save pointer receiver bug#42
Merged
Fix deprecated rand.Seed and Crontab.Save pointer receiver bug#42
Conversation
- Remove deprecated rand.Seed() call in lib/utils.go (#21). Since Go 1.20+ the global rand is automatically seeded, and the per-call re-seeding was actually causing identical values within the same second. - Change Crontab.Save from value receiver to pointer receiver so that setting c.IsSaved = true actually persists on the caller's struct (#22). - Add tests for both fixes. https://claude.ai/code/session_01CukrzEXPeaab9By46BLrG3
aflanagan
force-pushed
the
claude/prioritize-open-issues-AwBXl
branch
7 times, most recently
from
d70a846 to
0514241
Compare
Collaborator
|
i don't see IsSaved being read anywhere, we can just remove it. |
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated rand.Seed() call in lib/utils.go (fix deprecated use of rand.Seed #21). Since Go 1.20+ the global rand is automatically seeded, and the per-call re-seeding was actually causing identical values within the same second.
Change Crontab.Save from value receiver to pointer receiver so that setting c.IsSaved = true actually persists on the caller's struct (crontab.Save does not update crontab field #22).
Add tests for both fixes.