feat: Add styling properties for nodes and edges in system diagrams#265
Open
hardiksinh wants to merge 5 commits intomainfrom
Open
feat: Add styling properties for nodes and edges in system diagrams#265hardiksinh wants to merge 5 commits intomainfrom
hardiksinh wants to merge 5 commits intomainfrom
Conversation
Collaborator
hardiksinh
commented
Feb 2, 2026
hardiksinh
commented
- Introduced backgroundColor, borderColor, borderWeight, borderStyle, and fontColor properties for nodes and edges.
- Updated the SystemGraphView to utilize context-stroke for markers.
- Enhanced DiagramNodeView and CrossModelEdgeView to apply custom styling based on node and edge arguments.
- Modified grammar and AST to support new styling attributes.
- Added example diagram with various styling configurations for nodes and edges.
Unit Test Results 2 files 15 suites 20s ⏱️ Results for commit f14abca. ♻️ This comment has been updated with latest results. |
harmen-xb
requested changes
Feb 2, 2026
Contributor
harmen-xb
left a comment
harmen-xb
left a comment
There was a problem hiding this comment.
Nice work! I added some questions and one request to update a protocol file so keywords are escaped correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.