Skip to content

Conversation

@LaurenceJJones
Copy link
Member

Add permissive ParseURL function that falls back to storing the raw
value in URL.Opaque when Go's url.Parse fails. This fixes CONNECT
requests with authority-form URIs like 116.202.157.104:80.

Fixes #4152

We want to ensure that we dont get in the way of requests getting to coraza an early error means it never gets there.

   Add permissive ParseURL function that falls back to storing the raw
   value in URL.Opaque when Go's url.Parse fails. This fixes CONNECT
   requests with authority-form URIs like 116.202.157.104:80.

   Fixes crowdsecurity#4152
@github-actions
Copy link

github-actions bot commented Feb 2, 2026

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Feb 2, 2026

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones LaurenceJJones changed the title appsec: handle unparseable URLs gracefully fix(appsec): handle unparseable URLs gracefully Feb 2, 2026
@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.62%. Comparing base (5da924c) to head (6d1d90b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4270      +/-   ##
==========================================
+ Coverage   63.07%   63.62%   +0.55%     
==========================================
  Files         472      455      -17     
  Lines       33426    32694     -732     
==========================================
- Hits        21082    20802     -280     
+ Misses      10224     9818     -406     
+ Partials     2120     2074      -46     
Flag Coverage Δ
bats 46.61% <66.66%> (+0.02%) ⬆️
unit-linux 35.92% <83.33%> (-0.07%) ⬇️
unit-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[appsec]: Unable to parser URL due to semi colon

1 participant