-
Notifications
You must be signed in to change notification settings - Fork 574
Migrate file acquisition + New tail_mode and stat_poll_interval settings to support not keeping file handles permanently open #4280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # pkg/acquisition/modules/file/run.go
|
@david-garcia-garcia: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@david-garcia-garcia: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4280 +/- ##
==========================================
+ Coverage 63.10% 63.23% +0.13%
==========================================
Files 472 474 +2
Lines 33458 33714 +256
==========================================
+ Hits 21113 21320 +207
- Misses 10224 10266 +42
- Partials 2121 2128 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/kind refactoring |
This is a POC of migrating tail to use context.
Unfortunately the underlying library used does not support context, so I just removed it.