Open
Conversation
Member
straight-shoota
left a comment
There was a problem hiding this comment.
We should add some specs for this new method.
ysbaddaden
requested changes
Jan 5, 2026
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/empty-content-when-reading-big-packets-on-tcp-ip/8652/4 |
ysbaddaden
approved these changes
Jan 19, 2026
Member
|
suggestion: We could refactor the implementation of def read_fully?(slice : Bytes) : Int32?
count = read_greedy(slice)
return nil unless count == slice.size
count
endThis could also be a follow-up. |
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
Contributor
Author
|
I applied all suggestions and added the cross-reference to the docs. |
straight-shoota
approved these changes
Jan 21, 2026
ysbaddaden
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14605
Adds the proposed
#read_greedymethod which tries to fill aSlicemultiple times if it was only filled partially by the read method.Since some users seem to expect this kind of behaviour from
#read(leading to hard-to-debug bugs), this could be seen as a "safer" version of #read for some use-cases.I didn't try to add a lazy reading function as there would be too many interpretations of what reading lazily even means depending on the use-case.
There's also a small optimization for IO::Memory (not benchmarked).