Ensure that heredoc lexing allows only valid identifiers#16548
Open
Sija wants to merge 1 commit intocrystal-lang:masterfrom
Open
Ensure that heredoc lexing allows only valid identifiers#16548Sija wants to merge 1 commit intocrystal-lang:masterfrom
Sija wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
Blacksmoke16
added
kind:bug
Contributor
Author
|
Does this PR needs sth to be reviewed? |
Collaborator
|
To be honest, I fail to see the problem, and the issue doesn't outline any trouble that may come from that. It's also a breaking change. |
straight-shoota
approved these changes
Feb 13, 2026
Member
There was a problem hiding this comment.
As mentioned in #15855 (comment), this is not critical, but still feels like the right thing to do.
I wouldn't expect violating heredoc delimiters to be used much (if at all), so the practical breaking effect is close to null.
I'd be willing to try it. If we notice anything bad happening, we can still backtrack.
ysbaddaden
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15855 (although it still allows
_as an identifier since it's valid elsewhere too)