Rotator controller: improve tracking with flips(go smooth near zenith).#140
Open
bychek wants to merge 2 commits intocsete:masterfrom
Open
Rotator controller: improve tracking with flips(go smooth near zenith).#140bychek wants to merge 2 commits intocsete:masterfrom
bychek wants to merge 2 commits intocsete:masterfrom
Conversation
added 2 commits
July 14, 2018 13:42
Owner
|
Hi @bychek Thanks for the patch. I am very busy at the moment, so it may take a while before I can review your patches. My original plan was to work on gpredict again around September/October and I don't think I will have much time before that, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rotators with 180+ degrees of elevation are capable to go near/through zenith smoothly, without large azimuth rotations. It's useful to keep antenna direction in tolerance limits.
One example to test is FO-29 pass over Moscow/Vnukovo at 18-06-07T17:03+03. I use "rotctld -m 1 --set-conf=min_az=0,max_az=360,max_el=180 -vvvvvv".
Central angle logic(first commit) is needed to implement smooth zenith flip. I'm not sure it makes sense to use the first commit alone. It's also an option to use central_angle() only for rotators with flip support, I'm not sure which way is better.
I'm also thinking about futher improvements in set_flipped_pass()/is_flipped_pass():