Feature: add the ability to filter members in the SOG nametrainer

[lodewiges]

This PR introduces the ability to filter for former members when using the nametrainer.
This fixes #872

Summary by CodeRabbit

• New Features
  • Added a toggle in the Namen leren (Name Trainer) UI allowing users to include or exclude former members from the training list. Checking the box expands the pool of names used during training; unchecking limits it to current members.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a checkbox UI toggle and a tracked showFormerMembers property; when disabled the controller filters fetched memberships to only include currently active members before mapping to users.

Changes

Cohort / File(s)	Summary
Controller & Template app/controllers/sog/name-trainer.js, app/templates/sog/name-trainer.hbs	Added a tracked showFormerMembers property. Controller's getUsers() fetches memberships into a mutable variable and, when showFormerMembers is false, filters memberships by userIsCurrentlyMember === true before mapping to users. Template adds a checkbox (id="show-former-members-check", class form-check-input) bound to this.showFormerMembers labeled "Ook oudleden trainen".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A checklist twitch, a whisker twitch more,
I hop through names upon the floor.
Toggle shows the old or only the new,
Rabbity rhythm, quick and true —
Training hops with clarity and cheer. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a filter feature to include/exclude former members in the SOG nametrainer application.
Description check	✅ Passed	The description provides a clear summary of changes, references the fixed issue (#872), and includes a screenshot showing the new UI element (checkbox for showing former members).
Linked Issues check	✅ Passed	The code changes directly address issue #872 by adding a showFormerMembers filter that prevents former members from appearing unless explicitly included via the new checkbox.
Out of Scope Changes check	✅ Passed	All changes are directly related to the stated objective: adding a filter control for former members in the nametrainer, with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/filter-sog

---

No actionable comments were generated in the recent review. 🎉

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Adds a UI toggle to include/exclude former members in the SOG name trainer, so the trainer can focus on current members by default while still allowing training on old members when desired.

Changes:

• Add a “Toon oudleden” checkbox to the name trainer settings screen.
• Add controller state (showFormerMembers) and apply membership filtering logic when loading users for the trainer.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
app/templates/sog/name-trainer.hbs	Adds checkbox UI to control whether former members are included.
app/controllers/sog/name-trainer.js	Tracks the new flag and filters memberships before building the trainer user list.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.01%. Comparing base (e5dc0bd) to head (1cc6c8d).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines	Patch %	Lines
app/controllers/sog/name-trainer.js	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           staging    #1071      +/-   ##
===========================================
- Coverage    13.02%   13.01%   -0.02%     
===========================================
  Files          450      450              
  Lines         3124     3127       +3     
===========================================
  Hits           407      407              
- Misses        2717     2720       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new former-member filtering behavior in getUsers() isn’t covered by tests. Given there are existing unit tests for controllers/routes in this repo, please add a test that verifies getUsers() returns only current members by default and includes former members when showFormerMembers is enabled (and that the returned list contains the associated user records).