fixed extraction of expanded tasks#89
Open
ak-cube wants to merge 1 commit intocubewise-code:masterfrom
Open
Conversation
MariusWirtz
reviewed
Nov 22, 2024
.vscode/launch.json
Outdated
| @@ -0,0 +1,16 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
Please exclude this file from the commit
MariusWirtz
reviewed
Nov 22, 2024
| expanded_tasks[task.id] = [expanded_task] | ||
| else: | ||
| expanded_tasks[task.id].append(expanded_task) | ||
| tasks = expanded_tasks |
Collaborator
There was a problem hiding this comment.
Good catch!
Please add a test case here. This way, we can be 100% sure that the issue is resolved and if someone accidentally breaks it in the future, we will detect it
https://github.com/cubewise-code/rushti/blob/master/tests/tests.py
The function has generated wrong execution order if processes have the same ID
Author
|
Hi! I updated the existing test case as the function "get_ordered_tasks_and_waits" is always executed with the parameter expand=True. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function has generated the wrong execution order if processes have the same ID.