Do not announce binary content of command #985
+94
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
do-not-announce-binaries
branch
from
d78a178 to
a38125b
Compare
mvz
force-pushed
the
do-not-announce-binaries
branch
from
a38125b to
ec50cb9
Compare
Contributor
Author
|
There is technically a small breaking change here in that |
The command_content announcer would announce the full binary file if the command happened to be a binary file. This change adds a check to make sure binary files are not announced. It uses the marcel MIME type detection gem for this.
mvz
force-pushed
the
do-not-announce-binaries
branch
from
ec50cb9 to
78488ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not announce binary executables when the
command_contentannouncer is active.Details
The
command_contentannouncer would announce the full binary file if the command happened to be a binary file.This change adds a check to
SpawnProcess#contentto make sure binary files are not announced. It uses the marcel MIME type detection gem for this.Motivation and Context
Fixes #667.
How Has This Been Tested?
I added specs for
SpawnProcess#content.Types of changes
Checklist: