Add specs for more command matchers #990
Merged
+93
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Alas, no test failure on Windows. Still merging since this is an improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add some specs for
#have_finished_in_timeand#run_too_longmatchersDetails
Motivation and Context
While attempting to get the cucumber scenarios to run on Windows (#968), it became clear that after a timeout Aruba's work directory does not get cleaned up properly.
The fact that this only became clear in the cucumber features is worrisome. Therefore, I'm adding specs so the timeout system gets exercised in the specs as well.
How Has This Been Tested?
I ran the specs on Linux.
I'm kind of hoping this fails on Windows.
Types of changes
Checklist: