better error handling when loading tasks using esm#133
Draft
better error handling when loading tasks using esm#133
Conversation
abendigo
force-pushed
the
marko/better-error-handling-esm-tasks
branch
from
2145726 to
f311e20
Compare
mattwynne
reviewed
Dec 23, 2022
| const world = new TestWorld(options) | ||
|
|
||
| // Load the task | ||
| await asyncAssignTasks(world, `${__dirname}/fixtures/tasks/goodtasks`) |
Member
There was a problem hiding this comment.
I don't understand something here.
On line 12 we've defined goodtask as () => Action<void> but that's also what's defined in the goodtask.ts fixture.
Should we be using the result of this call to asynAssignTasks to set up the goodtask property on our TestWorld on line 12, instead of hard-coding / duplicating it?
|
|
||
| // error compiling | ||
| it('fails with a helpful error message if the task could not be compiled', async () => { | ||
| class TestWorld extends ActorWorld { |
Member
There was a problem hiding this comment.
Do we need lines 26-30 for this test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Better Error Handling when loading tasks in an ESM environment.
⚡️ What's your motivation?
The errors were getting swallowed, slowing the addition of tests.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.