Add convenience finder methods by uuid and handle#68
Open
silviucm wants to merge 3 commits intocurrantlabs:masterfrom
Open
Add convenience finder methods by uuid and handle#68silviucm wants to merge 3 commits intocurrantlabs:masterfrom
silviucm wants to merge 3 commits intocurrantlabs:masterfrom
Conversation
Author
|
Hi @roylee17 - when you have a chance could you review this ? if approved, I would go on and fix the write part of the blesh tool |
Contributor
|
@silviucm sorry for the late response. Thanks for the input. Something like how Sort package works.
// (details or naming are left out) |
Author
|
@roylee17 fair enough. Changes updated |
Contributor
|
LGTM, thanks. |
Author
|
@roylee17 if you could approve this merge at your convenience, I could get going on the second part, fixing the blesh tool write part + a bit of documentation for it thanks |
Contributor
|
ping @hasty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds several convenience methods for identifying services, characteristics or descriptors, based on their uuid or handle, in addition to the original Find method.