fix: include firebase wrapper in notification service FCM podspec#540
Conversation
mahmoud-elmorabea
left a comment
There was a problem hiding this comment.
Hey @xavi-999
Thank you so much for trying to help out with this change!
Can you please expand on why you believe this is needed? CioFirebaseWrapper is only needed for the main SDK and for token handling. NSE target only handles richp push and tracking metrics and does not need this dependency.
|
Hey @mahmoud-elmorabea , thanks for your answer. As described in the PR description, the
Is this a mistake in the setup guidelines code? Consumers who have FCM/ObjC and try to setup pushes while copy pasting the sample code will always run into the error of |

Summary
Adds
CioFirebaseWrapperdependency tocustomerio-reactnative-richpush.podspecwhich is used by the Notification Service Extension and FCM consumers.In the setup push notifications guide,
CioFirebaseWrapperwas being imported inadvertently, the dependency was not present on the.podspecthat is used by the Extension.In the 4x -> 5.0.0 migration guide, it is also indicated that:
Check imports: Ensure you’ve added import CioFirebaseWrapper to all files that import CioMessagingPushFCM-> the Notification Service is one of them.In order to comply with the setup/troubleshoot guide and to ensure that the user does not have any build errors, the
.podspecnow includes theCioFirebaseWrapperdependency.Changes
Added
CioFirebaseWrapperdependency tocustomerio-reactnative-richpush.podspecunderFCM.Added
CioFirebaseWrapperimport to the Notification Service of the sample iOS app.Note
Adds
CioFirebaseWrapperto the FCM rich push podspec and imports it in the sample Notification Service for FCM builds.customerio-reactnative-richpush.podspec):CioFirebaseWrapperusingpackage["cioiOSFirebaseWrapperSdkVersion"].example/ios/NotificationServiceExtension/NotificationService.swift: whenUSE_FCM, addimport CioFirebaseWrapper.Written by Cursor Bugbot for commit 1f52114. This will update automatically on new commits. Configure here.