Skip to content

Conversation

@erictleung
Copy link
Contributor

New data has been added to the pixarfilms package and this change updates the genres schema accordingly.

Closes erictleung/pixarfilms#39

New data has been added to the pixarfilms package and this change
updates the genres schema accordingly.
@aviator-app
Copy link
Contributor

aviator-app bot commented Nov 27, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Collaborator

krlmlr commented Dec 8, 2024

Thanks. It looks like this needs more work. I have other material that relies on the fact that there's a film with no title in the current data. I'm thinking about copying the current state of the data here, perhaps pixarfilms can have a local, up-to-date version of dm_pixarfilms() . What do you think?

@erictleung
Copy link
Contributor Author

@krlmlr ah yes, I think you mentioned something about materials relying on missing data. The missing data happened to be for that one particular time point where Pixar didn't realize the name of the film yet.

And I'll try to occasionally keep the data up to date as Pixar will release more movies. So I'd agree that you can simply copy the current state of the data for dm and then I can simply write an up-to-date dm_pixarfilms() within pixarfilms. I already have a draft of it in a vignette https://github.com/erictleung/pixarfilms/blob/main/vignettes/use_dm.Rmd.

Feel free to close this PR and copy data from, say, the last release tag (https://github.com/erictleung/pixarfilms/releases/tag/v0.2.1), and then I'll create an up to date dm function in pixarfilms. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with dm's tests

2 participants