Open
Conversation
This commit adds a function `mapValue` for mapping a function over values of a given map
robin-aws
reviewed
Oct 21, 2021
| } | ||
|
|
||
| /* Map a function to the values of a map */ | ||
| function method {:opaque} mapValue<K, V, V'>(f: V -> V', m: map<K, V>): (m':map<K, V'>) |
Member
There was a problem hiding this comment.
Just a few suggestions:
Suggested change
| function method {:opaque} mapValue<K, V, V'>(f: V -> V', m: map<K, V>): (m':map<K, V'>) | |
| function method {:opaque} MapValues<K, V, V'>(f: V ~> V', m: map<K, V>): (m': map<K, V'>) |
- Pascal casing since that's what the style guide says:https://github.com/dafny-lang/libraries/blob/master/STYLE.md#naming-convention :)
- You're already accounting for partial functions in your
requires, but since you're declaringfto have typeV -> V', that meansfis a total function and its precondition is always just "true".V --> V'is the arrow type that allows for other non-trivial preconditions, and thenV ~> V'is the even more general arrow type that allows forreadsclauses as well. You'll have to add areadsclause to the function itself of course, something likereads set o | exists k in m.Keys :: o in f.reads(k).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a function
mapValuefor mapping a function over values of a given map