defaultIndex: return 404 + retry index logic#28
Open
DeviaVir wants to merge 1 commit intodaichirata:masterfrom
Open
defaultIndex: return 404 + retry index logic#28DeviaVir wants to merge 1 commit intodaichirata:masterfrom
DeviaVir wants to merge 1 commit intodaichirata:masterfrom
Conversation
Contributor
DeviaVir
commented
Oct 15, 2023
DeviaVir
commented
- This extends the defaultIndex logic to return a 404 for the index.html if it is not found.
- Additionally, we keep looking for the "defaultIndex.html" file in the URL path, by splitting off the last "/" and keep going up until we find it, or we are at the root (and need to return a 404).
This extends the defaultIndex logic to return a 404 for the index.html if it is not found. Additionally, we keep looking for the "defaultIndex.html" file in the URL path, by splitting off the last "/" and keep going up until we find it, or we are at the root (and need to return a 404).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.