Open
Conversation
- Remove max-width constraints on feed container for full-width layout - Reduce default grid gap from gap-8 (32px) to gap-4 (16px) - Unify page padding to laptop:p-10 on all sides Co-authored-by: Cursor <cursoragent@cursor.com>
- Make header fixed instead of sticky for YouTube-like behavior - Add hidden scrollbar that shows on hover - Improve sidebar collapse animation with synchronized 300ms transitions - Adjust sidebar padding and font sizes for consistency - Make plus icon always visible in section headers Co-authored-by: Cursor <cursoragent@cursor.com>
- Add aria-label to sidebar toggle button for accessibility - Fix section title opacity class for collapsed state - Update test to match renamed "Squads" section Co-authored-by: Cursor <cursoragent@cursor.com>
- Cast isVisible.current to boolean for aria-expanded - Remove unsupported variant prop from CreatePostButton Co-authored-by: Cursor <cursoragent@cursor.com>
- Remove density settings from appearance page (hardcode to 'eco') - Debounce sidebar state change to prevent layout jump during animation - Use proper link for 'Add to Feeds' button instead of router.push() Co-authored-by: Cursor <cursoragent@cursor.com>
Reverts the removal of max-width calculation that was causing cards to stretch too wide on large displays. Co-authored-by: Cursor <cursoragent@cursor.com>
Cards now use full width on screens below 2560px, and only get constrained to 20rem per card on ultra-wide/4K displays. Co-authored-by: Cursor <cursoragent@cursor.com>
Aligns with design system by using the highest defined breakpoint (2156px) instead of arbitrary 2560px value. Co-authored-by: Cursor <cursoragent@cursor.com>
- Mobile/tablet: sticky header scrolls naturally with content - Desktop (laptop+): fixed header stays at top - Removes padding-top on mobile since header is sticky - Fixes gap issues on Squad and Jobs pages on mobile Co-authored-by: Cursor <cursoragent@cursor.com>
tsahimatsliah
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feed-layout-improvements.preview.app.daily.dev