Skip to content

Comments

feat: expose FUTURE_MONTHS as env var#397

Closed
gczobel wants to merge 1 commit intodaniel-hauser:mainfrom
gczobel:contribution-branch
Closed

feat: expose FUTURE_MONTHS as env var#397
gczobel wants to merge 1 commit intodaniel-hauser:mainfrom
gczobel:contribution-branch

Conversation

@gczobel
Copy link
Contributor

@gczobel gczobel commented Feb 28, 2025

FUTURE_MONTHS environment variable is not exposed making impossible to modify it without making a local modification of the scrape.yml file.

@daniel-hauser WDYT about add something similar for the cron?

on:
  schedule:
    - cron: ${{ vars.SCRAPE_CRON || '5 10,22 * * *' }}

DEBUG: ""
TZ: "Asia/Jerusalem"
DAYS_BACK: ${{ github.event.inputs.daysBack }}
FUTURE_MONTHS: ${{ vars.FUTURE_MONTHS }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if the variable is not defined for the repo?

@daniel-hauser
Copy link
Owner

daniel-hauser commented Mar 6, 2025

WDYT about add something similar for the cron?

AFAIR cron must be a constant, but i didn't find anything about it in the docs.
If you see it works, I'm fine with it

@daniel-hauser
Copy link
Owner

@gczobel Closing as stale, feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants