Resolved - Swift Access Races in multi-threading causing memory issues#53
Resolved - Swift Access Races in multi-threading causing memory issues#53fahidattique55 wants to merge 2 commits intodanielrhodes:masterfrom
Conversation
…to avoid swift access races.
|
thank you for fixing this, I had been working on tracking the same problem. your fork seems to do the trick for me. |
|
|
||
| fileprivate func onMessage(_ message: Message) { | ||
|
|
||
| queue.sync { |
There was a problem hiding this comment.
I wonder if this should use ActionCableSerialQueue ?
There was a problem hiding this comment.
I think sync operation can also be done with ActionCableSerialQueue. Btw, thanks for your thoughts.
|
Are you going to merge the pull request? |
|
Since the release of iOS 13, we noticed a lot of new crashes (com.ActionCableClient.Conccurent EXC_BAD_ACCESS KERN_INVALID_ADDRESS) related to Action Cable Client and usually pointing to We've been using this PR in production for a week and all those crashes are gone, so thank you for your contribution! |
|
Thanks for the appreciation. It means a lot. |
|
@danielrhodes it would be great to see this merged. Alternatively - if you're not able to maintain this project any more for whatever reason, it would be great if you could let people know so that someone else can step in. thanks :) |
4 participants
This has been tested by my team for multiple days and we did not found any multi-threading issue after QA. So I think i'ts stable now and you can merge it in new versions of it.