Fixed headers setter and channel uid#56
Open
NicosKaralis wants to merge 6 commits intodanielrhodes:masterfrom
Open
Fixed headers setter and channel uid#56NicosKaralis wants to merge 6 commits intodanielrhodes:masterfrom
NicosKaralis wants to merge 6 commits intodanielrhodes:masterfrom
Conversation
Signed-off-by: Nicos Karalis <nicoskaralis@me.com>
NicosKaralis
changed the title
Signed-off-by: Nicos Karalis <nicoskaralis@me.com>
AlexHuryn
reviewed
Jun 20, 2019
| //if identifier isn't empty, fetch the first value as the channel unique identifier | ||
| if let dictionary = identifier?.first { | ||
| channelUID = dictionary.value as! String | ||
| if let dictionary = identifier, dictionary.count > 1 { |
There was a problem hiding this comment.
why do you ignore the case when dictionary.count == 1 ?
Signed-off-by: Nicos Karalis <nicoskaralis@me.com>
kaomte
added a commit
to tekkinnovations/ActionCableClient2
that referenced
this pull request
Jan 2, 2021
- General fixes so that it compiles under XCode 12.0.1 - Applied fix for unique channel identifiers from here: danielrhodes/Swift-ActionCableClient#56 - Use sorted keys in JSON serialization for consistent serialization of identifier field. - Use Websocket delegate callbacks instead of blocks. - Adapted to new version of Starscream 4.0.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve issue #55