Three fixes see details in description#102
Open
jeremydumais wants to merge 4 commits intodanish1658:mainfrom
Open
Three fixes see details in description#102jeremydumais wants to merge 4 commits intodanish1658:mainfrom
jeremydumais wants to merge 4 commits intodanish1658:mainfrom
Conversation
jeremydumais
commented
Jan 14, 2024
jeremydumais
commented
- Integrated the pull request Added defaultOptions to Multi Select List #86 of KoalaBear
- Fix: If a search value existed, it was not reloaded in the search box when the list was displayed.
- Fix: Default options were not registered when using a useEffect. The firstRender was happening before.
- Fix: When using the save mode 'key' and setting values as default options, the component didn't set selected keys correctly.
… when the list was displayed.
…_firstRender was happening before.
…tions, the component didn't set selected keys correctly.
|
As KoalaBear mentioned, I saw that MultipleSelectList has a defaultOptions property, but it is not implemented. I am working on an app right now where this functionality would be very helpful. Please get this reviewed and merge soon. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.