Skip to content

DAOS-18296 rdb: Call vos_pool_create/open in ULTs#17302

Merged
daltonbohning merged 4 commits intomasterfrom
liw/stack-overflow
Jan 14, 2026
Merged

DAOS-18296 rdb: Call vos_pool_create/open in ULTs#17302
daltonbohning merged 4 commits intomasterfrom
liw/stack-overflow

Conversation

@liw
Copy link
Contributor

@liw liw commented Dec 22, 2025 •
edited
Loading

Call vos_pool_create and vos_pool_open in new deep-stack ULTs on the xstream to avoid pmemobj_create and pmemobj_open from potentially overflowing caller stacks.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Ticket title is 'dmg system start causes engines to crash after pool create'
Status is 'In Progress'
Labels: 'scrubbed_2.8'
https://daosio.atlassian.net/browse/DAOS-18296

@liw liw force-pushed the liw/stack-overflow branch from 82bee02 to e9c2f12 Compare December 22, 2025 04:40
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Dec 23, 2025

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17302/3/testReport/

@liw liw force-pushed the liw/stack-overflow branch 3 times, most recently from 6d82a18 to 6cc64dc Compare December 24, 2025 23:46
@liw liw marked this pull request as ready for review January 6, 2026 04:30
@liw liw requested review from a team as code owners January 6, 2026 04:30
@liw liw force-pushed the liw/stack-overflow branch from 6cc64dc to b529916 Compare January 6, 2026 04:31
@janekmi
Copy link
Contributor

janekmi commented Jan 6, 2026

FYI this patch won't be necessary when this patch to PMDK will land: daos-stack/pmdk#28
The work goes full steam ahead. I would expect it to be resolved by the end of this week.

@liw
Copy link
Contributor Author

liw commented Jan 7, 2026

FYI this patch won't be necessary when this patch to PMDK will land: daos-stack/pmdk#28 The work goes full steam ahead. I would expect it to be resolved by the end of this week.

@janekmi, @grom72, thanks for the pmdk work. At the daos level, we'd like to make this call change regardless, just in case.

@liw
DAOS-18296 rdb: Call vos_pool_create/open in ULTs
897f96b 
Call vos_pool_create and vos_pool_open in new deep-stack ULTs on the
xstream to avoid pmemobj_create, pmemobj_open, and SPDK from potentially
overflowing caller stacks.

Allow-unstable-test: true
Signed-off-by: Li Wei <liwei@hpe.com>
@liw liw force-pushed the liw/stack-overflow branch from b529916 to 897f96b Compare January 7, 2026 02:17
@liw liw requested review from NiuYawei and kccain January 7, 2026 02:18
@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 7, 2026

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17302/9/execution/node/1271/log

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 7, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17302/10/testReport/

kccain
kccain previously approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@kccain kccain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (other than copyright out of date already noted by linting)

NiuYawei
NiuYawei previously approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@NiuYawei NiuYawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright is out of date.

liw added 2 commits January 8, 2026 10:51
@liw
Merge branch 'master' into liw/stack-overflow
6930c3a
@liw
Fix copyright dates
8b5e062 
Allow-unstable-test: true
Signed-off-by: Li Wei <liwei@hpe.com>
@liw liw dismissed stale reviews from NiuYawei and kccain via 8b5e062 January 8, 2026 01:54
@liw
Copy link
Contributor Author

liw commented Jan 8, 2026

Errrhhh, thanks. Fixed.

@daosbuild3
Copy link
Collaborator

daosbuild3 commented Jan 13, 2026

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17302/12/testReport/

@liw liw requested a review from a team January 14, 2026 04:53
@liw liw added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jan 14, 2026
@daltonbohning daltonbohning merged commit 8a24f84 into master Jan 14, 2026
39 of 41 checks passed
@daltonbohning daltonbohning deleted the liw/stack-overflow branch January 14, 2026 13:55
liw added a commit that referenced this pull request Feb 7, 2026
@liw
DAOS-18296 rdb: Call vos_pool_create/open in ULTs (#17302)
21f566b 
Call vos_pool_create and vos_pool_open in new deep-stack ULTs on the
xstream to avoid pmemobj_create and pmemobj_open from potentially
overflowing caller stacks.

Signed-off-by: Li Wei <liwei@hpe.com>
liw added a commit that referenced this pull request Feb 7, 2026
@liw
DAOS-18296 rdb: Call vos_pool_create/open in ULTs (#17302)
09dd3a6 
Call vos_pool_create and vos_pool_open in new deep-stack ULTs on the
xstream to avoid pmemobj_create and pmemobj_open from potentially
overflowing caller stacks.

Signed-off-by: Li Wei <liwei@hpe.com>
mchaarawi pushed a commit that referenced this pull request Feb 26, 2026
@liw
DAOS-18296 rdb: Call vos_pool_create/open in ULTs (#17302) (#17525)
c7d661b 
Call vos_pool_create and vos_pool_open in new deep-stack ULTs on the
xstream to avoid pmemobj_create and pmemobj_open from potentially
overflowing caller stacks.

Signed-off-by: Li Wei <liwei@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@kccain kccain kccain approved these changes

Assignees

No one assigned

Labels

forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@liw @daosbuild3 @janekmi @NiuYawei @kccain @daltonbohning