Conversation
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @janekmi)
ChangeLog line 6 at r1 (raw file):
- PMem HW tests have been reorganized. (daos-stack/pmdk#9-12) - A new home for pmdk software has been set up.
Suggestion:
- A new home for pmdk software has been set up (pmem/pmdk -> daos/pmdk).
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
ChangeLog line 6 at r1 (raw file):
- PMem HW tests have been reorganized. (daos-stack/pmdk#9-12) - A new home for pmdk software has been set up.
Done.
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @janekmi)
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)
ChangeLog line 13 at r2 (raw file):
force-disabled. - Conversely, pmemobj_open() does not issue a warning when attempting to open a pool with SDS disabled while the feature is force-disabled.
- Active forms consistently.
- Wrote why we decided to reorganize HW tests. It is not just for the fun of it. 😄
Suggestion:
- Set up a new home for pmdk software (pmem/pmdk -> daos-stack/pmdk).
- Reorganized PMem HW tests to accommodate changes in HW supplies (daos-stack/pmdk#9-12).
- Expanded the sds.at_create CTL to also cover pmemobj_open() (daos-stack/pmdk#5, DAOS-17449)
- Previously, this CTL affected only pmemobj_create().
- Now, it affects both pmemobj_create() and pmemobj_open().
- pmemobj_open() won't be able to open a pool with SDS enabled if the feature is currently
force-disabled.
- Conversely, pmemobj_open() does not issue a warning when attempting to open a pool with SDS disabled
while the feature is force-disabled.
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
ChangeLog line 13 at r2 (raw file):
Previously, janekmi (Jan Michalski) wrote…
- Active forms consistently.
- Wrote why we decided to reorganize HW tests. It is not just for the fun of it. 😄
Done.
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk)
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
This change is