Skip to content

common: update Changelog.md#20

Merged
janekmi merged 3 commits intomasterfrom
changelog_fix
Oct 27, 2025
Merged

common: update Changelog.md#20
janekmi merged 3 commits intomasterfrom
changelog_fix

Conversation

@osalyk
Copy link
Contributor

@osalyk osalyk commented Oct 22, 2025

This change is Reviewable

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
@osalyk osalyk requested review from grom72 and janekmi October 22, 2025 09:51
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @janekmi)


ChangeLog line 6 at r1 (raw file):


	- PMem HW tests have been reorganized. (daos-stack/pmdk#9-12)
	- A new home for pmdk software has been set up.

Suggestion:

- A new home for pmdk software has been set up (pmem/pmdk -> daos/pmdk).

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


ChangeLog line 6 at r1 (raw file):


	- PMem HW tests have been reorganized. (daos-stack/pmdk#9-12)
	- A new home for pmdk software has been set up.

Done.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@grom72 reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)


ChangeLog line 13 at r2 (raw file):

	  force-disabled.
	  - Conversely, pmemobj_open() does not issue a warning when attempting to open a pool with SDS disabled
	  while the feature is force-disabled.
  1. Active forms consistently.
  2. Wrote why we decided to reorganize HW tests. It is not just for the fun of it. 😄

Suggestion:

	- Set up a new home for pmdk software (pmem/pmdk -> daos-stack/pmdk).
	  - Reorganized PMem HW tests to accommodate changes in HW supplies (daos-stack/pmdk#9-12).
	- Expanded the sds.at_create CTL to also cover pmemobj_open() (daos-stack/pmdk#5, DAOS-17449)
	  - Previously, this CTL affected only pmemobj_create().
	  - Now, it affects both pmemobj_create() and pmemobj_open().
	  - pmemobj_open() won't be able to open a pool with SDS enabled if the feature is currently
	  force-disabled.
	  - Conversely, pmemobj_open() does not issue a warning when attempting to open a pool with SDS disabled
	  while the feature is force-disabled.

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


ChangeLog line 13 at r2 (raw file):

Previously, janekmi (Jan Michalski) wrote…
  1. Active forms consistently.
  2. Wrote why we decided to reorganize HW tests. It is not just for the fun of it. 😄

Done.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@janekmi reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi merged commit b4db741 into master Oct 27, 2025
9 checks passed
@janekmi janekmi deleted the changelog_fix branch November 10, 2025 10:41
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants