Conversation
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
grom72
left a comment
There was a problem hiding this comment.
My proposal is to change schedules as:
pmem_test_1 -> Friday 6pm (+8h)
pmem_test_2 -> Saturday 6am (+12h)
pmem_test_3 -> Saturday 6pm
let's build everything during weekend
@grom72 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
left a comment
There was a problem hiding this comment.
I gave more time between pmem_test_2 and pmem_test_3, the workflow can take up to 24 hours. We don't know yet how long it takes.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @grom72 and @janekmi)
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @osalyk)
.github/workflows/pmem_tests_1.yml line 34 at r2 (raw file):
if: github.repository_owner == 'daos-stack' runs-on: [self-hosted, pmdk, rhel, icx] timeout-minutes: 1440 # 24h
Suggestion:
# 3h (as measured + a generous safety margin).
timeout-minutes: 180
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
.github/workflows/pmem_tests_1.yml line 34 at r2 (raw file):
if: github.repository_owner == 'daos-stack' runs-on: [self-hosted, pmdk, rhel, icx] timeout-minutes: 1440 # 24h
We don't want to correct it anymore.
I gave the longest possible timeout; if it doesn't fit, it will have to be split anyway.
janekmi
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @osalyk)
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
This change is