Skip to content

Split pmem_test_3.yml and update README.md file#23

Merged
janekmi merged 8 commits intomasterfrom
split-pmem3-tests
Nov 19, 2025
Merged

Split pmem_test_3.yml and update README.md file#23
janekmi merged 8 commits intomasterfrom
split-pmem3-tests

Conversation

@osalyk
Copy link
Contributor

@osalyk osalyk commented Nov 19, 2025

This change is Reviewable

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)


.github/workflows/pmem_tests_3.yml line 4 at r1 (raw file):

#
# This workflow is run on 'self-hosted' runners.
name: PMEM tests part 3 (helgrind)

I am not sure this is a good idea. Parts created so far do not have any description except for a number and you decided also not to put it in the badge.

If you decide to keep it anyway please just put it in the badge as well so the workflow would be at least named consistently.


README.md line 114 at r1 (raw file):

For more information on this library, contact
Tomasz Gromadzki (tomasz.gromadzki@hpe.com),
Jan Michalski (jan.michalski@hpe.com),

Suggestion:

jan-marian.michalski@hpe.com

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)


.github/workflows/pmem_tests_3.yml line 4 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

I am not sure this is a good idea. Parts created so far do not have any description except for a number and you decided also not to put it in the badge.

If you decide to keep it anyway please just put it in the badge as well so the workflow would be at least named consistently.

Done.


README.md line 114 at r1 (raw file):

For more information on this library, contact
Tomasz Gromadzki (tomasz.gromadzki@hpe.com),
Jan Michalski (jan.michalski@hpe.com),

Done.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed 1 of 3 files at r2.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi)


README.md line 116 at r2 (raw file):

Jan Michalski (jan-marian.michalski@hpe.com),
Oksana Sałyk (oksana.salyk@hpe.com), or post to
the [Persistent Memory Programming Google group](https://groups.google.com/group/pmem).

Will we support the Google group?

Suggestion:

Oksana Sałyk (oksana.salyk@hpe.com).

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also consider to change test matrix:

test_script: [sh, py]
os: [opensuse, rhel]
build: [debug, nondebug]

To force opensuse to be run before rhel?

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @janekmi and @osalyk)


.github/workflows/pmem_tests_3.yml line 4 at r2 (raw file):

#
# This workflow is run on 'self-hosted' runners.
name: PMEM tests part 3

Suggestion:

Functional tests with Helgrind

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed all commit messages.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's forget about it.

Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed 1 of 3 files at r2.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @janekmi and @osalyk)


README.md line 112 at r2 (raw file):

## Contact Us

For more information on this library, contact

Suggestion:

project

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janekmi reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)


README.md line 114 at r3 (raw file):

For more information on this project, contact
Tomasz Gromadzki (tomasz.gromadzki@hpe.com),
Jan Michalski (jan-marian.michalski@hpe.com),

Suggestion:

Jan Michalski (jan-marian.michalski@hpe.com), or

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @osalyk)


.github/workflows/pmem_tests_4.yml line 10 at r2 (raw file):

  schedule:
    # run this job at 18:00 UTC every Sunday
    - cron:  '0 18 * * 0'

24h after Helgrind

Suggestion:

    # run this job at 6:00 UTC every Monday
    - cron:  '0 6 * * 1'

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed 1 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grom72 reviewed 1 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)

Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @grom72 and @janekmi)


README.md line 116 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Will we support the Google group?

Done.


.github/workflows/pmem_tests_4.yml line 10 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

24h after Helgrind

Done.


README.md line 112 at r2 (raw file):

## Contact Us

For more information on this library, contact

Done.


README.md line 114 at r3 (raw file):

For more information on this project, contact
Tomasz Gromadzki (tomasz.gromadzki@hpe.com),
Jan Michalski (jan-marian.michalski@hpe.com),

Done.

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@grom72 reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@janekmi reviewed 1 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@janekmi janekmi merged commit d7abff0 into master Nov 19, 2025
9 checks passed
osalyk added a commit that referenced this pull request Jan 14, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 14, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 14, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk added a commit that referenced this pull request Jan 16, 2026
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants