Split pmem_test_3.yml and update README.md file#23
Conversation
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72)
.github/workflows/pmem_tests_3.yml line 4 at r1 (raw file):
# # This workflow is run on 'self-hosted' runners. name: PMEM tests part 3 (helgrind)
I am not sure this is a good idea. Parts created so far do not have any description except for a number and you decided also not to put it in the badge.
If you decide to keep it anyway please just put it in the badge as well so the workflow would be at least named consistently.
README.md line 114 at r1 (raw file):
For more information on this library, contact Tomasz Gromadzki (tomasz.gromadzki@hpe.com), Jan Michalski (jan.michalski@hpe.com),
Suggestion:
jan-marian.michalski@hpe.comSigned-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @grom72 and @janekmi)
.github/workflows/pmem_tests_3.yml line 4 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
I am not sure this is a good idea. Parts created so far do not have any description except for a number and you decided also not to put it in the badge.
If you decide to keep it anyway please just put it in the badge as well so the workflow would be at least named consistently.
Done.
README.md line 114 at r1 (raw file):
For more information on this library, contact Tomasz Gromadzki (tomasz.gromadzki@hpe.com), Jan Michalski (jan.michalski@hpe.com),
Done.
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 of 3 files at r2.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi)
README.md line 116 at r2 (raw file):
Jan Michalski (jan-marian.michalski@hpe.com), Oksana Sałyk (oksana.salyk@hpe.com), or post to the [Persistent Memory Programming Google group](https://groups.google.com/group/pmem).
Will we support the Google group?
Suggestion:
Oksana Sałyk (oksana.salyk@hpe.com).
grom72
left a comment
There was a problem hiding this comment.
Shall we also consider to change test matrix:
test_script: [sh, py]
os: [opensuse, rhel]
build: [debug, nondebug]
To force opensuse to be run before rhel?
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
grom72
left a comment
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 4 unresolved discussions (waiting on @janekmi and @osalyk)
.github/workflows/pmem_tests_3.yml line 4 at r2 (raw file):
# # This workflow is run on 'self-hosted' runners. name: PMEM tests part 3
Suggestion:
Functional tests with Helgrind
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed all commit messages.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
grom72
left a comment
There was a problem hiding this comment.
Let's forget about it.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 of 3 files at r2.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @janekmi and @osalyk)
README.md line 112 at r2 (raw file):
## Contact Us For more information on this library, contact
Suggestion:
projectSigned-off-by: Oksana Salyk <oksana.salyk@hpe.com>
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)
README.md line 114 at r3 (raw file):
For more information on this project, contact Tomasz Gromadzki (tomasz.gromadzki@hpe.com), Jan Michalski (jan-marian.michalski@hpe.com),
Suggestion:
Jan Michalski (jan-marian.michalski@hpe.com), or
grom72
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @osalyk)
.github/workflows/pmem_tests_4.yml line 10 at r2 (raw file):
schedule: # run this job at 18:00 UTC every Sunday - cron: '0 18 * * 0'
24h after Helgrind
Suggestion:
# run this job at 6:00 UTC every Monday
- cron: '0 6 * * 1'
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 of 3 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 1 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
osalyk
left a comment
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @grom72 and @janekmi)
README.md line 116 at r2 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Will we support the Google group?
Done.
.github/workflows/pmem_tests_4.yml line 10 at r2 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
24h after Helgrind
Done.
README.md line 112 at r2 (raw file):
## Contact Us For more information on this library, contact
Done.
README.md line 114 at r3 (raw file):
For more information on this project, contact Tomasz Gromadzki (tomasz.gromadzki@hpe.com), Jan Michalski (jan-marian.michalski@hpe.com),
Done.
grom72
left a comment
There was a problem hiding this comment.
@grom72 reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)
grom72
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
janekmi
left a comment
There was a problem hiding this comment.
@janekmi reviewed 1 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @osalyk)
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
Signed-off-by: Oksana Salyk <oksana.salyk@hpe.com>
This change is