Skip to content

obj: add footer ignoring for valgrind #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janekmi merged 2 commits into from
Dec 16, 2025
+6 −1
Merged

obj: add footer ignoring for valgrind #27

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f760edf
obj: add footer ignoring for valgrind
osalyk Dec 11, 2025
1286734
obj: improve comment
osalyk Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libpmemobj/memblock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1174,6 +1174,12 @@ huge_write_footer(struct chunk_header *hdr, uint32_t size_idx)
struct chunk_header f = *hdr;
f.type = CHUNK_TYPE_FOOTER;
f.size_idx = size_idx;

/*
* footers are metadata that is replayed when rebuilding the heap
* and do not require transactional or persistent storage
*/
VALGRIND_ADD_TO_GLOBAL_TX_IGNORE(hdr + size_idx - 1, sizeof(f));
*(hdr + size_idx - 1) = f;
/* no need to persist, footers are recreated in heap_populate_buckets */
VALGRIND_SET_CLEAN(hdr + size_idx - 1, sizeof(f));
Expand Down
Loading