Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently block process and blob process both return the same
BlockError. While convenient there are many variants ofBlockErrorthat don't make sense for blob process.This PR explores having dedicated error types for:
ProcessBlockError: returned byprocess_block(verifies block and callsimport_block)ProcessBlobError: returned byprocess_blob(verifies blob and callsimport_block)BlockImportError: returned byimport_blockIf we want to have a common routine in sync for block component at some level we have to coerce block and blob errors into the same thing.