Updated EOS 2000D BlackAreas cameras.xml#718
Updated EOS 2000D BlackAreas cameras.xml#718PeterWem wants to merge 1 commit intodarktable-org:developfrom
Conversation
This change solves darktable-org#717 and is cropping out the first 4 columns from left optical black area.
|
for RPU sample, exiftool says: Is the output identical for that raw too? #389 is the main culprit here, a few bad rows/cols shouldn't normally cause so dramatic effect. |
|
Same. The sample from RPU says firmware 1.0.0. The one I got has 1.1.0 To me it seems like Canon didn't mask those 4 columns at all with this camera. Never seen that before with Canon. |
|
Huh, that's bizarre. And the horizontal black area in |
That should be good, shouldn't it? 4 lines down to crop out nonsens pixels and ending 30 lines down instead of 36 not getting too close to the active image pixels. Or do you mean the part that is 0? |
|
With permission to share this raw file here for everyone, https://drive.google.com/file/d/1fAzOCo2dGLM6yJfyJB-yG34KyFTRmfgg/view?usp=drive_link I asked the photographer about high ISO shot because the different parts of the optical black area are more visible. The red part is the missing masked pixels. I don't know what the blue part is but many raw files from Canon look like that. Is it how things work in sensor when the image first is captured? It begins to read the sensor from that part? Purple part is the masked pixels we use to set the black level. What about the green part? I see that part at higher ISO from different Canon models. |
Are these maybe similar in value to the pixels at the right border? Could be a timing issue w/ the sensor readout, and the last 4 pixels on the right actually end up as the first 4 pixels on the next row (and the whole image ends up shifted by 4)... In any case, the x value can be 4, as it is zero based. |
Please change the pos to be a multiple of 2 (in either direction), i'll merge this then i guess. |


This change solves #717 and is cropping out the first 4 columns from left optical black area when the first 4 columns are not black.