Merged
Conversation
…hand (v, vert etc.)
…onstants Horizontal (h, horiz, horizontal) shows the list and preview windows side-by-side and the vertical layout (v, vert, vertical) shows the windows stacked with list on the top and preview on the bottom.
There was a problem hiding this comment.
Pull Request Overview
This PR implements stacking (vertical) layout support for the task selector UI, allowing users to stack the task list above the preview window as an alternative to the default side-by-side horizontal layout.
- Adds vertical layout option with
height_ratioconfiguration for controlling list vs preview height distribution - Implements layout toggling functionality via
:TaskToggleLayoutcommand with session persistence - Adds comprehensive UI constants and validation for both horizontal and vertical layouts
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/taskfile/ui_spec.lua | Extensive test coverage for vertical layout behavior, window sizing, and layout toggling |
| tests/taskfile/setup_spec.lua | Validation tests for height_ratio configuration and layout option parsing |
| tests/minimal_init.lua | Test environment improvements with better dependency management |
| plugin/taskfile.lua | New TaskToggleLayout command implementation |
| lua/taskfile/utils.lua | UI constants consolidation and layout normalization utilities |
| lua/taskfile/ui.lua | Core vertical layout implementation and window positioning logic |
| lua/taskfile/core.lua | Configuration schema updates and improved task execution handling |
| demo/demo.tape | Demo updates showcasing layout toggle functionality |
| Taskfile.yml | Added format task for code formatting |
| README.md | Documentation updates for new layout features |
Comments suppressed due to low confidence (2)
lua/taskfile/core.lua:1
- [nitpick] The variable name
total_weightis misleading as it represents width, not weight. It should be renamed tototal_widthfor consistency with other similar variables in the codebase.
---@Class core
lua/taskfile/ui.lua:1
- The magic number
2should be replaced with theui.const.WINDOW_GAPconstant that is already defined and used elsewhere in the file.
--@Class ui
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
adb0bb6 to
8d77c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.