Conversation
9b42f87 to
b4d9a83
Compare
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
af24393 to
d4078d7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for additional type checkers (pyright and basedmypy) to the CI workflow and updates type stub files to address compatibility issues. The changes enable testing with multiple type checkers to ensure broader type safety coverage.
- Adds pyright and basedmypy as new dependency groups in pyproject.toml
- Updates CI workflow to run mypy, basedmypy, and pyright on integration test files
- Refactors variable naming in type stub files to avoid conflicts and improve clarity
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds new dependency groups for pyright and basedmypy type checkers |
| .github/workflows/ci.yml | Refactors file collection logic and adds basedmypy and pyright steps to CI |
| tests/integration/test_numpy1p0.pyi | Updates variable names to avoid conflicts (a_ns → has_ns, a_ns → _) |
| tests/integration/test_numpy2p0.pyi | Renames underscore variables to numbered format and reorganizes comments |
| tests/integration/test_numpy2p2.pyi | Renames underscore variable to descriptive name and adds explanatory comment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jorenham
reviewed
Aug 22, 2025
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Collaborator
Author
|
@jorenham pyright & basedpyright now work |
Collaborator
Author
|
Ping @jorenham. Ready for merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.