Add Support for ByteSize and TimeDuration Token Parsers with Aggregation Directive#984
Open
Chayandas07 wants to merge 5 commits intodata-integrations:developfrom
Open
Add Support for ByteSize and TimeDuration Token Parsers with Aggregation Directive#984Chayandas07 wants to merge 5 commits intodata-integrations:developfrom
Chayandas07 wants to merge 5 commits intodata-integrations:developfrom
Conversation
- Introduced BYTE_SIZE and TIME_DURATION tokens in the ANTLR grammar. - Implemented ByteSize and TimeDuration classes for parsing and conversion. - Updated RecipeVisitor to handle new token types in directives. - Created AggregateStats directive for aggregating byte sizes and time durations. - Added unit tests for ByteSize and TimeDuration parsing. - Implemented integration tests for AggregateStats directive. - Updated pom.xml files to include necessary dependencies and plugins.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces new token parsers and a directive to support parsing and aggregation of byte size and time duration values in Wrangler recipes.
Key Features
✅ Lexer & Parser Enhancements
BYTE_SIZEwith support for units: B, KB, MB, GB, TB, PBTIME_DURATIONwith support for units: ns, us, ms, s, m, h, dDirectives.g4grammar to include:ByteUnit,TimeUnitfragmentsbyteSizeArg,timeDurationArgmvn compile✅ API Updates
ByteSize.java: Parses and normalizes byte sizesTimeDuration.java: Parses and converts durations to millisecondsTokenTypewithBYTE_SIZEandTIME_DURATION✅ Core Parser Integration
visitByteSizeArgandvisitTimeDurationArgin the recipe visitor✅ New Directive:
aggregate-statsExecutorContextstore to maintain intermediate state for aggregation✅ Testing
ByteSizeparsing (e.g., "2KB", "1.5MB")TimeDurationparsing (e.g., "100ms", "2.5h", "3min")Usage (Added to README)