Update ValidateStandardTest.java#996
Open
RudreeshJoshi wants to merge 1 commit intodata-integrations:developfrom
Open
Update ValidateStandardTest.java#996RudreeshJoshi wants to merge 1 commit intodata-integrations:developfrom
RudreeshJoshi wants to merge 1 commit intodata-integrations:developfrom
Conversation
In the ValidateStandardTest.java file, I updated the file path in the `getSpecsInArchive` method to use the correct file separator, which was causing issues on certain systems. File schemasRoot = new File(src.getLocation().getPath(), ValidateStandard.SCHEMAS_RESOURCE_PATH); This way, the path will be created correctly for both Windows and Unix-like systems without causing issues with the path separator.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Comment on lines
+53
to
+77
| throws IOException, NoSuchAlgorithmException { | ||
| Map<String, Standard> schemas = new HashMap<>(); | ||
| CodeSource src = ValidateStandard.class.getProtectionDomain().getCodeSource(); | ||
| if (src != null) { | ||
| File schemasRoot = | ||
| new File(src.getLocation().getPath(), ValidateStandard.SCHEMAS_RESOURCE_PATH); | ||
|
|
||
| if (!schemasRoot.isDirectory()) { | ||
| throw new IOException( | ||
| String.format("Schemas root %s was not a directory", schemasRoot.getPath())); | ||
| } | ||
|
|
||
| String hash = calcHash(new FileInputStream(f)); | ||
| schemas.put( | ||
| FilenameUtils.getBaseName(f.getName()), | ||
| new Standard(hash, FilenameUtils.getExtension(f.getName()))); | ||
| for (File f : schemasRoot.listFiles()) { | ||
| if (f.toPath().endsWith(ValidateStandard.MANIFEST_PATH)) { | ||
| continue; | ||
| } | ||
|
|
||
| String hash = calcHash(new FileInputStream(f)); | ||
| schemas.put( | ||
| FilenameUtils.getBaseName(f.getName()), | ||
| new Standard(hash, FilenameUtils.getExtension(f.getName()))); | ||
| } | ||
| } | ||
|
|
||
| return schemas; |
Contributor
There was a problem hiding this comment.
indentation issues, please address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the ValidateStandardTest.java file, I updated the file path in the
getSpecsInArchivemethod to use the correct file separator, which was causing issues on certain systems. File schemasRoot = new File(src.getLocation().getPath(), ValidateStandard.SCHEMAS_RESOURCE_PATH); This way, the path will be created correctly for both Windows and Unix-like systems without causing issues with the path separator.