get EKI signer address from grpc server #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 2, 2026 15:57
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
dai1975
changed the title
siburu
reviewed
Feb 9, 2026
relay/prover.go
Outdated
Comment on lines
391
to
399
| } else if len(messages) == 1 { | ||
| return []*elc.MsgAggregateMessages{ | ||
| &elc.MsgAggregateMessages{ | ||
| Signer: signers[0], | ||
| Messages: messages, | ||
| Signatures: signatures, | ||
| }, | ||
| }, nil | ||
| } |
Contributor
There was a problem hiding this comment.
This specialization is unnecessary, right?
Comment on lines
361
to
362
| messages = nil | ||
| signatures = nil |
Contributor
There was a problem hiding this comment.
You must also update signers in the same way as messages and signatures.
Contributor
There was a problem hiding this comment.
@dai1975 Not fixed yet? We need to reset signers by {batches[0].Signer, batches[1].Signer, ...} at the end of each iteration.
added 2 commits
February 9, 2026 09:57
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Signed-off-by: Daisuke Kanda <daisuke.kanda@datachain.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elc-updater stores the signer address for client use.