[BACK] pb de nouvelle colonne dans la database#303
Open
chloebarre wants to merge 5 commits intomainfrom
Open
Conversation
RiwsPy
approved these changes
Jul 16, 2025
Collaborator
RiwsPy
left a comment
RiwsPy
left a comment
There was a problem hiding this comment.
Merci !
J'ai mis quelques remarques pas bloquantes.
| ).fetchall() | ||
| existing_cols = {col[0] for col in columns_sql} | ||
|
|
||
| missing_cols = set(schema.keys()) - existing_cols |
Collaborator
There was a problem hiding this comment.
Tu savais que dict.keys() possède une compatibilité partielle avec les set ?
missing_cols = schema.keys() - existing_cols serait suffisant ici.
| return | ||
|
|
||
| # Mapping Polars -> SQL | ||
| type_mapping = { |
Collaborator
There was a problem hiding this comment.
Il y a un bout de code qui a l'air de faire l'inverse dans Historisateur.convert_types_for_sql.
Ce dictionnaire pourrait être utile ailleurs dans le code, je le sortirai de la méthode pour en créer une constante.
Comment on lines
96
to
101
| for col in missing_cols: | ||
| pl_type = schema[col] | ||
| sql_type = type_mapping.get(pl_type, "TEXT") | ||
| sql = text(f'ALTER TABLE "{table_name}" ADD COLUMN "{col}" {sql_type};') | ||
| conn.execute(sql) | ||
| conn.commit() |
Collaborator
There was a problem hiding this comment.
C'est bon sur le principe, idéalement il faudrait réduire les appels à la db en concaténant les requêtes pour n'en faire qu'une seule.
Peut-être quelque chose comme ça ?
add_columns = [… for col in missing_cols]
sql = text(f'ALTER TABLE "{table_name}" {", ".join(add_columns)};)
conn.execute(sql)
conn.commit()
RiwsPy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.