fix: await SMTP send to prevent emails from being silently dropped#511
Merged
cyrilledaily merged 1 commit intomainfrom Feb 18, 2026
Merged
fix: await SMTP send to prevent emails from being silently dropped#511cyrilledaily merged 1 commit intomainfrom
cyrilledaily merged 1 commit intomainfrom
Conversation
sendMailPromise was called without await in trySendMail, causing the Next.js serverless function to return the HTTP response and terminate before nodemailer completed the SMTP handshake. Emails were never actually delivered despite the API responding with 200 success. Also adds console.error logging on SMTP failures for production diagnostics. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Preview is deploying...| ℹ️ Name | 🔗 Infos & links |
|---|---|
| 🌱 Deploying commit | f732289 |
| 👁️ Preview | Generating preview app... |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendMailPromise()was called withoutawaitintrySendMail(), causing the Next.js serverless function to return the HTTP response and terminate before nodemailer completed the SMTP handshake. Emails were never actually delivered despite the API responding with200 OK.console.errorlogging on SMTP failures so issues are visible in Clever Cloud production logs.Context
This bug existed before PR #507 and was identified during its review, but #507 was merged before the fix could land. This is a standalone hotfix targeting
main.Changes
One line change in
front/utils/emails/send-email.ts:Test plan
Made with Cursor