Open
Conversation
Contributor
ThibaudDauce
commented
Jan 1, 2026
ThibaudDauce
commented
- Require feat: add MembershipRequest from org opendatateam/udata#3570
ThibaudDauce
force-pushed
the
new_membership_requests
branch
from
86d0345 to
9f0fe1b
Compare
| const submitNewMember = async (close: () => void) => { | ||
| if (!canSubmitNewMember.value) return | ||
|
|
||
| const submitInvitation = async (close: () => void) => { |
Contributor
There was a problem hiding this comment.
The handling of an already invited user is quite misleading. It show a default error in a toast but I don't think we should send the request at all
Contributor
Author
There was a problem hiding this comment.
I think it's fixed
| } | ||
| } | ||
|
|
||
| const canSubmitInvitation = computed(() => { |
Contributor
There was a problem hiding this comment.
Can we use useForm instead ? It would allow us to show proper validation errors
Co-authored-by: Nicolas KEMPF <nicolas@conciergerie.dev>
# Conflicts: # .github/workflows/e2e.yml # pages/admin/organizations/[oid]/members.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.