feat(notifications): add discussions notifications#915
feat(notifications): add discussions notifications#915nicolaskempf57 wants to merge 5 commits intomainfrom
Conversation
nicolaskempf57
requested review from
ThibaudDauce and
maudetes
as code owners
| {{ title }} | ||
| </p> | ||
| <p | ||
| v-if="notification.details.status === 'new_comment'" |
There was a problem hiding this comment.
Shouldn't we also display from who on new_discussion?
There was a problem hiding this comment.
it was not shown on new_discussion on Figma but we can
| :user="notification.details.discussion.user" | ||
| :with-link="false" | ||
| /> | ||
| <OrganizationOwner |
There was a problem hiding this comment.
Testing at the moment, seems like the notification shows the user and not the organization even when "answering as" an organization, it may come from the notification itself.
There was a problem hiding this comment.
my bad, it should be about the comment here and not the discussion
| @click="markAsRead(notification)" | ||
| > | ||
| <template v-if="notification.details.status === 'new_comment'"> | ||
| {{ getLastComment(notification.details.discussion).content }} |
There was a problem hiding this comment.
It's also a limit from the notification itself, but I think the notification may not be about the last comment. Indeed, if we have 3 notifications on a discussion, we'll show the last comment here for every notification.
Maybe we could have the comment id in the notification backend (now that we have an id)?
2 participants
No description provided.