refactor: replace Marshmallow with Pydantic#149
Draft
bolinocroustibat wants to merge 27 commits intomainfrom
Draft
refactor: replace Marshmallow with Pydantic#149bolinocroustibat wants to merge 27 commits intomainfrom
bolinocroustibat wants to merge 27 commits intomainfrom
Conversation
bolinocroustibat
force-pushed
the
use-pydantic
branch
7 times, most recently
from
200d46e to
6859d10
Compare
bolinocroustibat
force-pushed
the
use-pydantic
branch
2 times, most recently
from
2eb3b6c to
9a20037
Compare
bolinocroustibat
force-pushed
the
use-pydantic
branch
8 times, most recently
from
dada589 to
dbfe2b3
Compare
bolinocroustibat
force-pushed
the
use-pydantic
branch
2 times, most recently
from
1607376 to
084aecc
Compare
bolinocroustibat
changed the title
bolinocroustibat
force-pushed
the
use-pydantic
branch
from
1faa334 to
d3ddf85
Compare
# Conflicts: # CHANGELOG.md # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # poetry.lock # pyproject.toml
# Conflicts: # CHANGELOG.md # poetry.lock
bolinocroustibat
added
code quality
Closes #310 Related discussion: https://mattermost.incubateur.net/betagouv/pl/1qt9fgsjw7yo3y8ii7u6y4xdmh Reduces congestion in high-priority queue while maintaining udata synchronization as a priority. **Priority resources in DB** (`priority=True`): Crawl and analysis use "default" priority **Non-priority resources in DB** (`priority=False`): Crawl and analysis use "low" priority **Udata notifications**: Always "high" priority (no change)
…resource (#313) Better, more informative logging in order to better analyse potential performance issues: - add `resource_id` info in timer logs - add new timer for analysing resource
bolinocroustibat
force-pushed
the
use-pydantic
branch
4 times, most recently
from
b936054 to
88bf2bc
Compare
bolinocroustibat
force-pushed
the
use-pydantic
branch
from
88bf2bc to
a00214b
Compare
# Conflicts: # CHANGELOG.md # poetry.lock # pyproject.toml # udata_hydra/analysis/resource.py # udata_hydra/cli.py # udata_hydra/routes/checks.py # udata_hydra/utils/errors.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150.
Replace Marshmallow with Pydantic
This old (almost 1 year-old), finally finished PR replaces the data validation library Marshmallow with Pydantic, a more modern and widely adopted alternative in the Python ecosystem.
Why this change:
• Broad adoption (notably in FastAPI), excellent documentation, and active maintenance
• Better performance (see discussion: HN – Why Pydantic is replacing Marshmallow)
• Pydantic relies on native Python type hints, making code more concise and readable and compatible with type checkers/IDEs
• Cleaner object-oriented approach, with models closer to enriched dataclasses
• Easy API input parameters validation