don't rais error on shudown #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR relaxes error handling during kernel shutdown so that common "already gone" or transient server errors no longer propagate as exceptions from shutdown_kernel.
Changes:
- In
KernelHttpManager.shutdown_kernel, broaden the set ofHTTPErrorstatus codes that are treated as non-fatal (ignored) during shutdown. - Log ignored shutdown errors with the raw HTTP status code rather than a hard-coded "kernel not found" message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| else: | ||
| raise | ||
| except BaseException as e: |
There was a problem hiding this comment.
Except block directly handles BaseException.
Suggested change
| except BaseException as e: | |
| except Exception as e: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.