Conversation
There was a problem hiding this comment.
Pull request overview
Updates runtime/process configuration for the Python service and adjusts Claude Code local permission allowlisting.
Changes:
- Simplifies the Python
Procfileuvicorn command by removing the fixed--workers 4setting. - Extends/reorders the
.claude/settings.local.jsonallowlist entries for additional Bash commands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/python/Procfile | Changes how the Python API is launched via Procfile (notably worker configuration). |
| .claude/settings.local.json | Updates the Claude Code local permissions allowlist. |
| @@ -1 +1 @@ | |||
| web: uvicorn main:app --host 0.0.0.0 --port 8080 --workers 4 No newline at end of file | |||
| web: uvicorn main:app --host 0.0.0.0 --port 8080 No newline at end of file | |||
There was a problem hiding this comment.
Procfile now runs uvicorn directly with a hard-coded port and without any way to configure worker count. Since this repo already has launcher.py to honor PORT and WORKERS (for Cloud Run / buildpacks), consider switching the Procfile command to invoke the launcher (or otherwise pass through env-based PORT/worker configuration) to avoid silently running single-worker in production.
| web: uvicorn main:app --host 0.0.0.0 --port 8080 | |
| web: python launcher.py |
| "Bash(git check-ignore:*)", | ||
| "Bash(git checkout:*)", | ||
| "Bash(git cherry-pick:*)", | ||
| "Bash(git commit:*)", | ||
| "Bash(git merge:*)", |
There was a problem hiding this comment.
This file appears to be intended as a developer-local Claude configuration, but the repository .gitignore ignores .claude/ and only whitelists settings.json and hooks/ (so settings.local.json is not meant to be version-controlled). If these permissions need to be shared, move them into .claude/settings.json; otherwise, consider removing settings.local.json from git tracking to avoid committing local preferences/permissions.
No description provided.