Update dependencies and remove unused ones#19
Open
Skunnyk wants to merge 11 commits intodbpedia-spotlight:masterfrom
Open
Update dependencies and remove unused ones#19Skunnyk wants to merge 11 commits intodbpedia-spotlight:masterfrom
Skunnyk wants to merge 11 commits intodbpedia-spotlight:masterfrom
Conversation
- Update to latest minor versions
- Still a WIP - Based on versions:display-dependency-updates, then try to update deps without breaking anything - Also using mvn dependency:analyze to remove unused deps (there are a lot !) - For now the rest server still works, haven't tested all cases.
- Still a WIP
- some log4j were still used and worked due to dependencie chain ... - Replace it with SpotlightLog - Still a WIP of course
- We don't need net.liftweb.lift-json_2.10 and net.sf.json-lib anymore - Their usage has been removed during the split of Lucene and Model (for spotlight 1.0) / Apache 2.0 Licensing
- UIMA and Mahout are not used anymore
- remove jersey-bundle and use correct dependencies - also rio/stax/trove
- Revert the jersey-bundle removal, spotlight is broken by declaring individual deps This reverts commit ce05d80.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update spotlight dependencies, I hope without breaking anything.
This is a big cleanup in pom.xml files, some dependencies were unused since a long time, other were outdated for ages etc.
Sometimes I removed bundle dep and replace them with needed packages
I also removed all the log4j things now that spotlight use slf4j.
The cleaning is based on mvn versions:display-dependency-update and dependency:analyze
If you can, please test ! (I haven't noticed any problems yet)