You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
BigQuery
Postgres
Redshift
Snowflake
I have updated the README.md (if applicable)
I have added tests & descriptions to my models (and macros if applicable)
Taking an initial look, your proposal is simple and aligns with all the other macros. Ideally, we'd add a test case that includes a "mIxEdCaSe" database name so that we can validate that all the data warehouse we test work in this scenario (and also to prevent regressions in the future). But that might prove to be a bit tricky / impractical. So we might need to fall back on some manual testing for this. I'm doing to do some manual testing with Postgres, Snowflake, and Databricks both with and without the changes in your PR. I'll report back later with those results.
This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingcase_sensitivityIssues related to case-sensitivity behaviorquotingIssues related to quoting behavior
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #900
Description & motivation
This fixes
get_relations_by_prefix()when the database name contains e.g. a hyphen on Postgres.Checklist