Fix small issue in Write File Record server response. Add user argument to Read Device Discovery Message#98
Open
indianaMitko62 wants to merge 5 commits intodebevv:masterfrom
Open
Fix small issue in Write File Record server response. Add user argument to Read Device Discovery Message#98indianaMitko62 wants to merge 5 commits intodebevv:masterfrom
indianaMitko62 wants to merge 5 commits intodebevv:masterfrom
Conversation
Owner
|
At the moment the buffer index is set to the end of the PDU, so that |
Author
|
That's a very good question. I don't remember why I did that. Why does it work in both occasions, though? |
indianaMitko62
changed the title
…t sections must be included in the responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the official MODBUS protocol documentation the normal response of a Write File Record request is an echo of the request. The whole request including the records data must be included in the response. This pull request makes sure the whole request is send as a response.
Link to the MODBUS documentation for reference: https://www.modbus.org/docs/Modbus_Application_Protocol_V1_1b3.pdf