more direct set up data model, tests passing#1193
Conversation
ea86964 to
b5dece5
Compare
b5dece5 to
9e5bde0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 73.57% 74.24% +0.67%
==========================================
Files 29 29
Lines 2293 2221 -72
==========================================
- Hits 1687 1649 -38
+ Misses 606 572 -34 ☔ View full report in Codecov by Sentry. |
|
I still think @NickCrews's ideas about breaking apart the DataModel object is good, but i think that we should be able to do that in a way that does not break backwards compatibility, so I think we don't need to try to bring it in now. |
|
@fgregg dedupe returns from the dead! 😉 Great to see some love happening here, thanks for your work! |
set up data models like
instead of
supersedes #1122, #1121. will close #1085
Todo:
This is is going to be a breaking change, so do we want to make bigger changes like splitting datamodel into feature creators and blocking rules, a la #1102?