feat: add support for non-orthogonal cells in amber/md format#870
Open
feat: add support for non-orthogonal cells in amber/md format#870
Conversation
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Feature Request] support non-orthogonal cells for amber/md
Add support for non-orthogonal cells in amber/md format
Aug 23, 2025
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #870 +/- ##
==========================================
+ Coverage 85.48% 85.53% +0.04%
==========================================
Files 82 82
Lines 7607 7625 +18
==========================================
+ Hits 6503 6522 +19
+ Misses 1104 1103 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed WallTime Performance ReportMerging #870 will not alter performanceComparing Summary
|
njzjz
requested changes
Aug 23, 2025
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
njzjz
reviewed
Aug 23, 2025
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Member
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
njzjz
approved these changes
Aug 23, 2025
Member
njzjz
left a comment
There was a problem hiding this comment.
The current state looks good to me - cell_lengths_angles_to_cell replaces the original code, and this method has a unit test that almost covers all cases. @wanghan-iapcm please double-check since this PR is LLM-generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
amber/mdformat previously only supported orthogonal unit cells (90° angles), raising aRuntimeError("Unsupported cells")for any simulation with non-orthogonal cells. This limitation prevented users from processing AMBER trajectories with triclinic, monoclinic, or hexagonal crystal systems.Changes
cell_lengths_angles_to_cell()function that converts cell lengths and angles to 3×3 cell vector matrices using standard crystallographic conventionsread_amber_traj()by replacing the angle check with general cell conversionSupported Crystal Systems
The implementation now handles all crystal systems:
Example Usage
Testing
Added comprehensive test coverage including:
All existing amber/md tests continue to pass, ensuring no breaking changes.
Fixes #869.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.